std::system() is not safe ; as a user could call this function with an input crafted to do malicious things...
So the solution would be to sanitize the inputs or the best solution is to use fork() and execvp() (for linux at least.)

I see, sorry I didn't know it was bad practice to use std::system. I'll make the changes for both macOS and linux.

I have replaced std::system with posix_spawn for Linux and popen for MacOS.
I haven't tested the MacOS implementation.

Apparently, popen does more or less the same as std::system so still unsecure if filename is badly formatted.
Claude (🫢) tells me that posix_spawn is doable on macOS as well so

    pid_t pid;
    char* argv[] = {
        const_cast<char*>("open"),
        const_cast<char*>(filename.c_str()),
        nullptr
    };
    
    int status = posix_spawn(&pid, "/usr/bin/open", nullptr, nullptr, argv, environ);
    if (status == 0) {
        waitpid(pid, &status, 0);
        success = ( WIFEXITED(status) && WEXITSTATUS(status) == 0);
    }

(similar to your linux version)

should be OK.

Thanks! I made the changes.